-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(templates): add fee abstraction into the scaffold chain template #4181
Conversation
Hi @julienrbrt, could you take a look at this PR? Thanks |
@faddat the chain template including feeabs generated from the CLI is working well. Please take a look at this, sir |
As discussed above, I have created a new template named "files-feeabs" that includes the fee abstraction module. The chain can be scaffolded using the --fee-abstraction flag. For example: ignite scaffold chain example --fee-abstraction. @julienrbrt please help me review this PR, sir |
This is a good temporary solution, thank you! When we have the module registry ready, we can make this fallback to the app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You actually only need to copy the files that are different from files/
instead of having everything. Other than that lgtm.
Thank you so much. I have removed the redundant template. Please take a look at this, sir. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! I think it is good for now.
In a follow-up we should refactor this to improve the UX and have a --external-modules
flag instead of a fee abstraction modules. As currently this module is mutually exclusive with the other, while it would be best if it was additive.
We can accept this on main, but we'll need to fix the UX before backporting on v28
IMHO, we should only add official modules. This way, we have more modules to maintain and add support; the fee abstraction module still needs some updates to be in the last stack. Let's add this integration as an app/extension |
100% agree, however to I wouldn't create an app per custom module but I more general app. This is someone I will be building. So to ship this faster maybe we should include it as it in v28 and improve it for v29 (like we will do for the consumer app). |
Hi, we just discussed this in our team call, we like this feature and want to integrate it right now. @Pantani is integrating this module as an Ignite App using hooks on the scaffold chain commands as we speak. |
Closes: #4171